Fix crowded header with a More overflow menu - #21
Merged
Merged
Conversation
ThreatCrush Security Scan7 finding(s) MEDIUM: 7
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header squeezed nine navigation links into one row, wrapping the logo and collection names. Keep Series One, Collect, and Contribute visible and move the other collections and GitHub into a More dropdown.
The dropdown supports keyboard navigation, Escape with focus restoration, and dismissal on outside click, focus leaving, or link selection. The mobile menu now scrolls within the viewport so every link remains reachable in landscape; both menus reset when crossing the mobile breakpoint.
Validation: production build and TypeScript passed; Chromium checks passed at 320, 375, 768, 880, 881, 1024, 1200, 1440, and 1920px. Verified all destinations remain accessible, no header wrapping or overflow, keyboard and pointer dismissal, link navigation, and scrolling to the last link at 568×320.